Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_iv_external_api_adaptor): update component_interface_specs dependency #126

Merged

Conversation

esteve
Copy link
Contributor

@esteve esteve commented Oct 16, 2024

PR Type

  • Bug Fix

Related Links

autowarefoundation/autoware.universe#9094

Description

Update dependency for component_interface_specs

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s).
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@esteve
Copy link
Contributor Author

esteve commented Oct 16, 2024

@isamu-takagi could you have a look at these changes when you have a moment? Also, could you review autowarefoundation/autoware.universe#9094 as well? Thanks.

@esteve esteve marked this pull request as draft October 21, 2024 22:28
@esteve
Copy link
Contributor Author

esteve commented Oct 21, 2024

Moving back to draft to update the namespaces as per autowarefoundation/autoware.universe#9094 (comment)

@esteve esteve force-pushed the prefix-component_interface_specs branch from 110ce6c to 5e2aae0 Compare October 21, 2024 22:40
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
@esteve esteve force-pushed the prefix-component_interface_specs branch from 5e2aae0 to 1fb730e Compare October 21, 2024 22:42
@esteve esteve marked this pull request as ready for review October 21, 2024 22:45
@esteve
Copy link
Contributor Author

esteve commented Oct 21, 2024

@isamu-takagi this is now ready for review again

Copy link
Collaborator

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx
Copy link

xmfcx commented Oct 29, 2024

@isamu-takagi -san,

has been merged. This should be quickly merged too for Autoware to compile.

@isamu-takagi isamu-takagi enabled auto-merge (squash) October 29, 2024 09:28
@isamu-takagi isamu-takagi merged commit 3de19bc into tier4:tier4/universe Oct 29, 2024
8 checks passed
@esteve esteve deleted the prefix-component_interface_specs branch October 29, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants