-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_iv_external_api_adaptor): update component_interface_specs dependency #126
refactor(autoware_iv_external_api_adaptor): update component_interface_specs dependency #126
Conversation
@isamu-takagi could you have a look at these changes when you have a moment? Also, could you review autowarefoundation/autoware.universe#9094 as well? Thanks. |
Moving back to draft to update the namespaces as per autowarefoundation/autoware.universe#9094 (comment) |
110ce6c
to
5e2aae0
Compare
…e_specs dependency Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
5e2aae0
to
1fb730e
Compare
@isamu-takagi this is now ready for review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@isamu-takagi -san, has been merged. This should be quickly merged too for Autoware to compile. |
PR Type
Related Links
autowarefoundation/autoware.universe#9094
Description
Update dependency for
component_interface_specs
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks