Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use cmd sleep for delay #50

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

hayato-m126
Copy link
Collaborator

@hayato-m126 hayato-m126 commented Nov 18, 2024

Types of PR

  • New Features

Description

  • use sleep and on_exit bag play

How to review this PR

git checkout feat/bag-play-delay-using-sleep
ros2 launch driving_log_replayer_v2 driving_log_replayer_v2.launch.py scenario_path:=${your_scenario}

before

/clock is published before topics in bag play replaying.

using_sleep.mp4

after

/clock is published same timing as topics in bag published.

using_delay.mp4

Others

closes: #49

Signed-off-by: Hayato Mizushima <[email protected]>
Copy link

sonarcloud bot commented Nov 18, 2024

Copy link
Contributor

@MasatoSaeki MasatoSaeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I checked this PR on local system with sensing:=false

@hayato-m126 hayato-m126 merged commit 0922831 into develop Nov 18, 2024
6 checks passed
@hayato-m126 hayato-m126 deleted the feat/bag-play-delay-using-sleep branch November 18, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore bag play delay to the same way as v1
2 participants