Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bag play remap #44

Merged
merged 2 commits into from
Nov 7, 2024
Merged

feat: bag play remap #44

merged 2 commits into from
Nov 7, 2024

Conversation

hayato-m126
Copy link
Collaborator

@hayato-m126 hayato-m126 commented Nov 7, 2024

Types of PR

  • New Features

Description

  • Allow users to add bag play remap with argument remap
# usage. for example remap gnss topics
❯ ros2 launch driving_log_replayer_v2 driving_log_replayer_v2.launch.py scenario_path:=$HOME/dlr2_data/localization/unlabeled.yaml remap:=/sensing/gnss/ublox/fix_velocity,/sensing/gnss/ublox/nav_sat_fix

It shows what is being remapped.
See remap_command is ['--remap', ...]

driving_log_replayer adds the topic to be remapped according to the use case, and the topic to be remapped specified by the user is displayed.

# launch command sample
[INFO] [launch]: All log files can be found below /home/hyt/.ros/log/2024-11-07-16-52-56-190738-dpc2405001-1683141
[INFO] [launch]: Default logging verbosity is set to INFO
[INFO] [launch.user]: t4_dataset_path=PosixPath('/home/hyt/dlr2_data/localization/bag_only_dataset'), dataset_index=0, output_dir=PosixPath('/home/hyt/dlr2_data/localization/out/2024-1107-165256'), use_case=localization
[INFO] [launch.user]: check_launch_component(conf)={'sensing': 'true', 'localization': 'true', 'perception': 'false', 'planning': 'false', 'control': 'false'}
[INFO] [launch.user]: conf.get('initial_pose')='{"position": {"x": 3839.340576171875, "y": 73731.3359375, "z": 19.639482498168945}, "orientation": {"x": -0.023971009814459248, "y": 0.005891999600528019, "z": -0.9709848597542231, "w": 0.237863568369043}}', conf.get('direct_initial_pose')=None
[INFO] [launch.user]: conf.get('goal_pose')=None
1730965983.766603 [77]       ros2: determined eno1 (udp/10.0.6.231) as highest quality interface, selected for automatic interface.
[WARNING] [launch_ros.actions.node]: Parameter file path is not a file: /home/hyt/ros_ws/unlabeled/install/individual_params/share/individual_params/config/default/pacmod/pacmod_extra.param.yaml
[INFO] [launch.user]: remap_command is ['--remap', '/sensing/lidar/concatenated/pointcloud:=/unused/concatenated/pointcloud', '/tf:=/unused/tf', '/localization/kinematic_state:=/unused/localization/kinematic_state', '/localization/acceleration:=/unused/localization/acceleration', '/sensing/gnss/ublox/fix_velocity:=/unused/sensing/gnss/ublox/fix_velocity', '/sensing/gnss/ublox/nav_sat_fix:=/unused/sensing/gnss/ublox/nav_sat_fix']

How to review this PR

Others

Signed-off-by: Hayato Mizushima <[email protected]>
Signed-off-by: Hayato Mizushima <[email protected]>
Copy link

sonarcloud bot commented Nov 7, 2024

Copy link
Contributor

@TadaKazuto TadaKazuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

動作させる環境が無いので、コードレビューのみとさせていただきます。準備でき次第動作確認します。

@hayato-m126 hayato-m126 merged commit 61ca6a9 into develop Nov 7, 2024
6 checks passed
@hayato-m126 hayato-m126 deleted the feat/bag-play-remap branch November 7, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants