address misc testthat 3e warnings

tidymodels · Oct 21, 2024 · 7128251 · 7128251
1 parent d4fc1d1
commit 7128251
Show file tree

Hide file tree

Showing 7 changed files with 8 additions and 8 deletions.
diff --git a/tests/testthat/test-cmprsk.R b/tests/testthat/test-cmprsk.R
@@ -46,6 +46,6 @@ test_that("tidy.cmprsk", {
     td3 %>%
       dplyr::select(conf.low, conf.high) %>%
       unclass() %>%
-      unname(),
+      unname()
   )
 })
diff --git a/tests/testthat/test-emmeans.R b/tests/testthat/test-emmeans.R
@@ -99,7 +99,7 @@ test_that("tidy.ref.grid consistency with tidy.TukeyHSD", {
 
   expect_equal(
     as.data.frame(td_hsd),
-    as.data.frame(td_pairs),
+    as.data.frame(td_pairs)
   )
 })
 

diff --git a/tests/testthat/test-glmnetUtils.R b/tests/testthat/test-glmnetUtils.R
@@ -56,7 +56,7 @@ test_that("tidy.glmnet.formula", {
   check_tidy_output(td2)
   check_tidy_output(td2z)
 
-  expect_is(td2, "tbl_df")
+  expect_s3_class(td2, "tbl_df")
 
   expect_equal(dim(td2), c(1511L, 6L))
   expect_equal(dim(td2z), c(2000L, 6L))
@@ -75,6 +75,6 @@ test_that("glance.glmnet.formula", {
 
   check_glance_outputs(gl, gl2)
 
-  expect_is(gl, "tbl_df")
+  expect_s3_class(gl, "tbl_df")
   expect_equal(dim(gl), c(1L, 3L))
 })
diff --git a/tests/testthat/test-mass-polr.R b/tests/testthat/test-mass-polr.R
@@ -50,7 +50,7 @@ test_that("augment.polr", {
   )
 
   au <- augment(fit, type.predict = "class")
-  expect_is(au$.fitted, "factor")
+  expect_s3_class(au$.fitted, "factor")
   expect_equal(predict(fit, type = "class"), au$.fitted)
 })
 

diff --git a/tests/testthat/test-multcomp.R b/tests/testthat/test-multcomp.R
@@ -56,7 +56,7 @@ test_that("tidy.glht consistency with tidy.TukeyHSD", {
   expect_equal(
     as.data.frame(td_hsd),
     as.data.frame(td_glht),
-    check.attributes = FALSE,
+    ignore_attr = TRUE,
     tolerance = 0.001
   )
 })
diff --git a/tests/testthat/test-stats-mlm.R b/tests/testthat/test-stats-mlm.R
@@ -8,7 +8,7 @@ df_tidy <- tidy(fit_mlm, conf.int = TRUE)
 
 test_that("tidy.mlm works", {
   expect_equal(dim(df_tidy), c(4L, 8L))
-  expect_is(df_tidy, "tbl_df")
+  expect_s3_class(df_tidy, "tbl_df")
 })
 
 #' helper function: replicate each element of x

diff --git a/tests/testthat/test-stats-prcomp.R b/tests/testthat/test-stats-prcomp.R
@@ -81,5 +81,5 @@ test_that("augment.prcomp works with matrix objects", {
   expect_equal(dim(df1), c(1000L, 15L))
   expect_equal(dim(df2), c(1000L, 47L))
   testthat::expect_equal(tibble::as_tibble(pred), df1[, -1])
-  expect_is(df1, "tbl_df")
+  expect_s3_class(df1, "tbl_df")
 })