[V2] SbsaQemu-rme: Add support for SBSA-rme platform #243
Conversation
Add support for SBSA-rme platform by 1) pushing the start of the base memory to 0x10043000000 to make room to the RMM and 2) increasing the size of FLASH0 to accomotate the RMM. Enabling RMM is done by specifying -D ENABLE_RME on the build command line. The name of the flag was chosen to reflect what is currently done on TF-A. Signed-off-by: Mathieu Poirier <[email protected]>
mathieupoirier
requested review from
ardbiesheuvel,
hrw and
leiflindholm
as code owners
| @@ -97,6 +97,10 @@ Create a directory $WORKSPACE that would hold source code of the components. | |||
| cd $WORKSPACE | |||
| build -b RELEASE -a AARCH64 -t GCC5 -p edk2-platforms/Platform/Qemu/SbsaQemu/SbsaQemu.dsc | |||
| ``` | |||
| An RME aware SBSA system can be compiled by adding `-D ENABLE_RME` to the | |||
| command line above. In that case `bl1.bin` and `fip.bin` also have to be RME | |||
| aware. Please refer to TF-A instructions to generate RME enabled binaries. | |||
There was a problem hiding this comment.
Please add link to those instructions.
There was a problem hiding this comment.
I am in the process of upstreaming the TF-A part and as such those instructions don't exists yet. I added this here so that we don't forget but I can also remove - it's up to you.
There was a problem hiding this comment.
It is better to have something like this than nothing ;D
|
|
||
| # Space for 32 stacks | ||
| gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|0x1000007c000 |
There was a problem hiding this comment.
I wonder can we have something like this:
gArmPlatformTokenSpaceGuid.PcdCPUCoresStackBase|gArmTokenSpaceGuid.PcdSystemMemoryBase+0x7c000
This would remove a need for extra "if".
There was a problem hiding this comment.
Checked. Such definition works so code can be a bit simpler.
There was a problem hiding this comment.
@leiflindholm may know why we reserve space for 31 stacks (31 x 0x4000 = 0x7c000) when comment says about 32 of them (so 0x80000).
There was a problem hiding this comment.
@hrw https://github.com/tianocore/edk2/blob/master/ArmPlatformPkg/Sec/AArch64/ModuleEntryPoint.S#L33
It's a weird pattern, but it adds up.
Ultimately, I guess we should only reserve the one stack these days? @ardbiesheuvel?
Hi Maintainers,
Please find herein the second revision of this set. Following our converstion from the first iteration, I am using a command line flag to enable RME support. I also took the initiative of adding some documentation to avoid having to look in the configuration files to remember the exact command line option to use.
Thanks for the time,
Mathieu