IntelSiliconPkg: Code Quality Improvements #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
requested review from
nate-desimone,
niruiyu and
SaiChaganty
as code owners
SaiChaganty
approved these changes
Sep 27, 2024
|
@SaiChaganty, are you going to merge this? |
SaiChaganty
reviewed
Oct 2, 2024
Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c
Show resolved
Hide resolved
yes. but please address the feedback I've provided (something I missed during my previous review) |
Prevent invalid DMAR ACPI table dereference if the table is not found. Signed-off-by: Michael Kubacki <[email protected]>
…parison SmmAccessDxe: `mSmmAccess.NumberRegions` is a `UINTN` while the loop index variable compared against it is a `UINT8`. This can lead to an overflow of the loop index for `mSmmAccess.NumberRegions` for values larger than `UINT8_MAX`. This change makes `Index` a `UINTN` to match in width. PeiSmmAccessLib: Fixes a similar `UINT8` loop index issue. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
intel_si_pkg_codeql
branch
from
c539812
to
eac8ed1
Compare
SaiChaganty
approved these changes
Oct 3, 2024
AshrafAliS
approved these changes
Oct 3, 2024
|
Merged #215<#215> to master.
From: Michael Kubacki ***@***.***>
Sent: Wednesday, October 2, 2024 8:27 PM
To: tianocore/edk2-platforms ***@***.***>
Cc: Chaganty, Rangasai V ***@***.***>; Mention ***@***.***>
Subject: Re: [tianocore/edk2-platforms] IntelSiliconPkg: Code Quality Improvements (PR #215)
@makubacki commented on this pull request.
________________________________
In Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/IntelVTdDmarPei.c<#215 (comment)>:
@@ -514,7 +515,9 @@ InitVTdInfo (
ASSERT (VTdInfo != NULL);
AcpiDmarTable = GetAcpiDmarTable ();
- ASSERT (AcpiDmarTable != NULL);
+ ASSERT (AcpiDmarTable != NULL);
Thanks, it's updated. I missed that porting it over from another codebase.
-
Reply to this email directly, view it on GitHub<#215 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AFBQJJRMYUIPPPO4SPEZHSDZZS2Q3AVCNFSM6AAAAABO723PQSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNBUGU3TAMJWGY>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits:
IntelSiliconPkg/IntelVTdDmarPei: Prevent invalid dereference
Prevent invalid DMAR ACPI table dereference if the table is not
found.
IntelSiliconPkg/SmmAccess: Fix potential integer overflow in loop comparison
SmmAccessDxe:
mSmmAccess.NumberRegionsis aUINTNwhile the loop index variablecompared against it is a
UINT8. This can lead to an overflow of theloop index for
mSmmAccess.NumberRegionsfor values larger thanUINT8_MAX. This change makesIndexaUINTNto match in width.PeiSmmAccessLib:
Fixes a similar
UINT8loop index issue.