ManageabilityPkg: Add IpmiCommandLib PEI instance #213
Conversation
Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLibPei.inf
Outdated
Show resolved
Hide resolved
Features/ManageabilityPkg/Library/IpmiCommandLib/IpmiCommandLibPei.inf
Outdated
Show resolved
Hide resolved
This introduces IpmiCommandLib/IpmiCommandLibPei.inf for the support of the IPMI command library in PEI. It is consistent with the IpmiLib which has supported separately an instance in PEI. Signed-off-by: Nhi Pham <[email protected]>
nhivp
force-pushed
the
add-IpmiCommandLibPei
branch
from
cf2c1ed
to
d013fa6
Compare
There was a problem hiding this comment.
Hi @nhivp, no technical issues, just want to confirm with you that, supposedly we don't have the specific code for edk2 boot phases in IpmiCommandLib library. Thus we don't have to separate the implementation into different folders such as Dxe/Smm/Pei, right?
Hi @changab Correct, the implementation remains consistent across phases. The extra INF for PEI simply ensures that the IPMI stack is buildable, as the IpmiLib has separate instances for PEI and DXE. |
|
Merged. |
This introduces IpmiCommandLib/IpmiCommandLibPei.inf for the support of the IPMI command library in PEI. It is consistent with the IpmiLib which has supported separately an instance in PEI.
Side-Note: Ampere Mt. Jade will use this library instance.