Katello 4.12 config addition, remove Koji tags and mash scripts from nightly

[qcjames53]

This is the config file for Katello 4.12 tooling plus the removal of koji and mash scripts from the nightly config moving forward. Please take care when reviewing this; this is my first branching so there is a good chance there are multiple mistakes in here :)

Notable questions:

• I updated flat-nodejs-14-el8 to flat-nodejs-16-el8
• Is centos8-devel still ok? I understand there have been issues with centos8 recently.

[ianballou]

I would recommend looking at both the Katello 4.11 config and nightly to figure out how it should look. I think some sections are missing, like the one that lists all relevant repos, or the one that lists all releases.

What I typically do is make the file match up with the nightly config and replace nightly keywords with "4.12". Then, check the prior release for missing sections.

Your release engineer can help point out anything that is missing, so feel free to ping them too.

Also, not a hard requirement, but look back to an older one like Katello 4.3... we used to give our releases fun code names but stopped at some point. I miss that a little :)

[ianballou]

Also, I totally agree that our documentation here is sorely lacking. The configuration is always been a messy part of branching. If you're interested it could be a great place to improve our branching guide.

[chris1984]

We want to add the sections that are in this file to your PR for tool_belt to pick up what cherrypicks needs to be made:

https://github.com/theforeman/tool_belt/blob/master/configs/katello/4.11.yaml#L9-L44

foreman-packaging goes to 3.10
hammer-cli-katello goes to 1.12.z
smart proxy container gateway goes to 1.2.0
katello-selinux stays the same
virt-who-configure goes to 0.5.20
cert tools and host tools stays the same
change the katello branch to 4.12

[qcjames53]

Just force pushed some new changes. Thanks for the help, Chris and Ian!

FYI I still left build_package_group_source_tag on nightly.

[chris1984]

Looks good on the 4.12 file, did you mean to push up the 4.11 file too?

[qcjames53]

I did not. A little confused why there is no diff. Let me take a look.

[qcjames53]

It is fixed. I needed to rebase again.

[chris1984]

few small comments then it's good to go

[chris1984]

ACK, the latest change looks good to me, I would adjust the PR title and commit message since we are changing the nightly and 4.11 config as well as 4.12 so we don't have confusion if we have to look back at this PR.

Will let @ekohl give the last word and look since I don't have merge rights

[chris1984]

Actually overlooked the 4.11 i see mash-scripts and tags still in that one, so either we should remove that one out of this pr and then keep your commit/pr message the same or adjust accordingly

[qcjames53]

I actually don't understand why 4.11 keeps getting added. I have not changed it. I'll remove it in a few minutes, sorry about that.

[qcjames53]

@chris1984 Are you ok with the PR title as it stands now (only 4.12 and nightly changed)?

[ekohl]

@qcjames53 regarding the commit message: imperative mood is the proper tense for the summary (first line).

[qcjames53]

Done. Thank you @ekohl :)

[qcjames53]

Added the endings you requested, thanks :)

[ekohl]

From a technical point of view 👍 and I started the tests. I didn't check the version numbers.

[chris1984]

ACK, looks good from a version standpoint based on the comments I left in the PR discussion and the file looks good now with the stuff gone that is no longer needed. @ekohl can you merge it?