try to use the fqdn for pulpcore urls #43
Conversation
evgeni
force-pushed
the
pulp-urls
branch
2 times, most recently
from
fba32c8
to
89b99ed
Compare
Those URLs are used by Katello and clients to connect to Pulp and `localhost` is almost never the right choice here as it will be either not reachable (for clients) or have the wrong certs (for Katello). Try to obtain the FQDN of the system from Facter, if available and fall back to `Socket.gethostname` (which is not guaranteed to return a FQDN) otherwise.
| fqdn = begin | ||
| require 'facter' | ||
| Facter.fact('networking.fqdn').value | ||
| rescue StandardError, LoadError |
There was a problem hiding this comment.
TIL that LoadError is not a StandardError…
|
These defaults are sort of development values. and I always assumed people would set this explicitly because I don't trust autodetection. |
I think the only way to enforce that is to not have a default value and ensure users think about / set this value. I would tend to prefer no default value other than a default specified in the settings file. |
|
If there is no sane default, don't have one in the first place. That makes a lot of sense to me. |
|
I guess the sanity is debatable, yeah. Would y'all prefer if I'd just drop the localhost default values, and mark the settings as required? |
|
Works for me. Saves doing these lookups regardless of whether a setting is configured (which can fail or slow things down) |
Those URLs are used by Katello and clients to connect to Pulp and
localhostis almost never the right choice here as it will be eithernot reachable (for clients) or have the wrong certs (for Katello).
Try to obtain the FQDN of the system from Facter, if available and fall
back to
Socket.gethostname(which is not guaranteed to return a FQDN)otherwise.