Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theforeman-rubocop gem and Rubocop configuration #10

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

archanaserver
Copy link
Contributor

Added theforeman-rubocop gem to v0.1.0 and the rubocop configuration, followed by default style from the gem.

default.yml: https://github.com/theforeman/theforeman-rubocop/?tab=readme-ov-file#basic-style---default-performance-and-rails-cops

This is part of Rubocop standerdization, link for the reference: https://community.theforeman.org/t/standardizing-rubocop-with-theforeman-rubocop/37239

Added theforeman-rubocop gem to v0.1.0 and the rubocop configuration,
followed by default style from the gem.
@archanaserver
Copy link
Contributor Author

@ofedoren this is passing now, can you take a look on this one?

Copy link
Member

@ofedoren ofedoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @archanaserver, let's get this in.

@ofedoren ofedoren merged commit 06f97bf into theforeman:master Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants