Halt upgrades if evr is not owned by foreman #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehelms
reviewed
Nov 16, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
ehelms
reviewed
Nov 16, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
ehelms
reviewed
Nov 16, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
ehelms
reviewed
Nov 16, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
ehelms
reviewed
Nov 16, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
ianballou
force-pushed
the
halt-upgrade-remote-db-evr-permissions
branch
2 times, most recently
from
4cd6c7a
to
a54ac48
Compare
ianballou
force-pushed
the
halt-upgrade-remote-db-evr-permissions
branch
from
a54ac48
to
d4d3d5b
Compare
|
All the comments should be addressed now. |
ehelms
reviewed
Nov 18, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
ehelms
reviewed
Nov 18, 2024
| unless evr_owned_by_postgres.empty? | ||
| return evr_owned_by_postgres.first['evr_owned_by_postgres'] == '0' | ||
| end | ||
| fail!('Could not determine if the evr extension is owned by the foreman DB owner') |
There was a problem hiding this comment.
What do we expect a user that hits this fail statement to do next? Can we give them some direction?
There was a problem hiding this comment.
The only failures reasons I can think of would be if the DB connection failed or if the config doesn't have the correct username information. I've updated the error message.
ehelms
reviewed
Nov 18, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
ehelms
reviewed
Nov 18, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
ianballou
force-pushed
the
halt-upgrade-remote-db-evr-permissions
branch
from
40e70cd
to
d86def9
Compare
|
I stopped hardcoding 'foreman' as the DB name just in case. We are hardcoding it in the installer check, but I figured why not here since it seems to be supported. |
ehelms
reviewed
Nov 18, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
ehelms
reviewed
Nov 18, 2024
definitions/checks/foreman/check_external_db_evr_permissions.rb
Outdated
Show resolved
Hide resolved
|
I had just a minor nit, @evgeni please also do a final review |
ianballou
force-pushed
the
halt-upgrade-remote-db-evr-permissions
branch
from
d86def9
to
e6dc6f1
Compare
ehelms
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Halts upgrades if the
evrextension in Katello external DBs are not owned byforeman. Skips the checks if theevrextension does not exist.Related installer PR: theforeman/foreman-installer#984