-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change --whitelist to --skip #723
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for renaming because it really is a blacklist
, rather than a whitelist
. Still, skip
is an even better description.
@@ -44,7 +44,7 @@ def upgrade_runner | |||
validate_target_version! | |||
@upgrade_runner = ForemanMaintain::UpgradeRunner.new(target_version, reporter, | |||
:assumeyes => assumeyes?, | |||
:whitelist => whitelist || [], | |||
:whitelist => skip || [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it also internally refactor?
The whitelist option doesn't accurately capture what will happen when steps are supplied to the option. The change to --skip can help to better understand that steps included with it will be skipped.
d751d89
to
1fbaad5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to keep --whitelist
but issue a deprecation warning?
The whitelist option doesn't accurately capture what will happen when steps are supplied to the option. The change to --skip can help to better understand that steps included with it will be skipped.