-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on unconfined selinux module #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the late response.
Looking at the thread, the Smart Proxy service ends up running unconfined and I'd say that in most setups we have that running on the same machine. Can you tell me why you don't want to depend on the unconfined service?
Today we don't really support the foreman-proxy
SELinux module and nobody is working on completing it so I'm not sure we can improve this.
As part of our security policy, we disable the unconfined module on all systems. Because the policy is dependent on the unconfined module, we are unable to install it on the server or a smart proxy. When we encounter applications that do not work correctly without the unconfined module, we will create auxiliary modules to correct any issues. We prefer to leverage the upstream modules that are provided when they exist. We cannot leverage the foreman-selinux without patching the policy and rebuilding the rpm. The comment regarding the dependency on the unconfined modules dependency states it is a temporary policy to prevent excess logging. We are proposing this temporary policy become optional for those like us who want to disable the unconfined module. |
That helps to understand this.
I'm happy to merge patches to address this. Today it's not supported because it's not finished (#168 sort of proves that).
That's fine by me. And I suspect that if you do run foreman-proxy within a policy you may not need to connect to unconfined TCP sockets, though I don't think there's a policy for puppetserver either which could shift the problem where foreman-proxy connects to an unconfined service. To move this forward, could you please open a Redmine issue on https://projects.theforeman.org/projects/selinux and link it here? |
|
I'd have expected to send an email, but I've now activated your user. |
I thought I had it configured not to require activation at all if you login via GitHub 🤔 |
646ace8
to
7e68f14
Compare
7e68f14
to
5c7e45d
Compare
Following up to see if anything else is needed to move this request forward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just kicked off CI. @evgeni any objections?
Thanks @matthewdva! |
Moved the temporary rule to prevent dontaudit denies during startup to an optional policy. This change removed the dependence on the unconfined selinux module.