Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on unconfined selinux module #172

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

matthewdva
Copy link

Moved the temporary rule to prevent dontaudit denies during startup to an optional policy. This change removed the dependence on the unconfined selinux module.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late response.

Looking at the thread, the Smart Proxy service ends up running unconfined and I'd say that in most setups we have that running on the same machine. Can you tell me why you don't want to depend on the unconfined service?

Today we don't really support the foreman-proxy SELinux module and nobody is working on completing it so I'm not sure we can improve this.

@matthewdva
Copy link
Author

As part of our security policy, we disable the unconfined module on all systems. Because the policy is dependent on the unconfined module, we are unable to install it on the server or a smart proxy.

When we encounter applications that do not work correctly without the unconfined module, we will create auxiliary modules to correct any issues. We prefer to leverage the upstream modules that are provided when they exist. We cannot leverage the foreman-selinux without patching the policy and rebuilding the rpm.

The comment regarding the dependency on the unconfined modules dependency states it is a temporary policy to prevent excess logging. We are proposing this temporary policy become optional for those like us who want to disable the unconfined module.

@ekohl
Copy link
Member

ekohl commented Nov 1, 2024

As part of our security policy, we disable the unconfined module on all systems. Because the policy is dependent on the unconfined module, we are unable to install it on the server or a smart proxy.

That helps to understand this.

When we encounter applications that do not work correctly without the unconfined module, we will create auxiliary modules to correct any issues. We prefer to leverage the upstream modules that are provided when they exist. We cannot leverage the foreman-selinux without patching the policy and rebuilding the rpm.

I'm happy to merge patches to address this. Today it's not supported because it's not finished (#168 sort of proves that).

The comment regarding the dependency on the unconfined modules dependency states it is a temporary policy to prevent excess logging. We are proposing this temporary policy become optional for those like us who want to disable the unconfined module.

That's fine by me. And I suspect that if you do run foreman-proxy within a policy you may not need to connect to unconfined TCP sockets, though I don't think there's a policy for puppetserver either which could shift the problem where foreman-proxy connects to an unconfined service.

To move this forward, could you please open a Redmine issue on https://projects.theforeman.org/projects/selinux and link it here?

@matthewdva
Copy link
Author

To move this forward, could you please open a Redmine issue on https://projects.theforeman.org/projects/selinux and link it here?
I have been trying to get a Redmine account so I can create an issue. I keep getting a message, "Your account was created and is now pending administrator approval." I am happy to create an issues once I can sign in.

@ekohl
Copy link
Member

ekohl commented Nov 1, 2024

I'd have expected to send an email, but I've now activated your user.

@evgeni
Copy link
Member

evgeni commented Nov 1, 2024

I thought I had it configured not to require activation at all if you login via GitHub 🤔

@ekohl ekohl changed the title Remove dependancy on unconfined selinux module Remove dependency on unconfined selinux module Nov 1, 2024
@matthewdva
Copy link
Author

Following up to see if anything else is needed to move this request forward.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just kicked off CI. @evgeni any objections?

@ekohl ekohl merged commit 93d3002 into theforeman:develop Nov 18, 2024
8 checks passed
@ekohl
Copy link
Member

ekohl commented Nov 18, 2024

Thanks @matthewdva!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants