-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update foreman_ygg_worker to 0.3.0 #11296
base: rpm/develop
Are you sure you want to change the base?
Update foreman_ygg_worker to 0.3.0 #11296
Conversation
30503d4
to
c3771fb
Compare
Please hold on until I get a confirmation that we should be creating the group ourselves. Edit: Not needed, yggdrasil ships a sysusers definition which handles the group creation |
c3771fb
to
cedf83f
Compare
cedf83f
to
d1417fb
Compare
@adamruzicka could you please rebase on the latest changes by Ewoud in rpm/develop? |
d1417fb
to
933f399
Compare
Well, this is tricky. foreman_ygg_worker-0.3.0 is now compatible with yggdrasil 0.2.z and 0.4.z (not sure about 0.3.z, probably too but who knows). However, the way we deploy yggdrasil is not compatible with yggdrasil >=0.4 until #11317 lands |
[test rpm-copr] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack from the functional side, tested together with theforeman/katello-pull-transport-migrate#8
Packaging wise this looks fine.
(assuming ygg 0.4, for all of the above) |
In general yes to all three.
Also yes, with "the process" being tweaked in theforeman/foreman#10340 |
And you can't do the stuff from #11317 in |
I need the post thingy to be run when yggdrasil itself gets updated to handle the service rename, which doesn't necessarily have to happen in the same transaction as when f_y_w is changed, so having it in f_y_w's post could miss this situation. The config file changes could be done at any time, but the service rename is tricky. |
My main concern was that people need to install that package somehow, but in most cases (most: https://github.com/theforeman/foreman-packaging/pull/11317/files#r1822445063) this will happen automatically, so it's probably fine. I still don't like this. But I also don't see a good way around it. |
No description provided.