Bump yggdrasil to 0.4.1 #11181
Draft
Bump yggdrasil to 0.4.1 #11181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welp, el7 has |
ekohl
reviewed
Aug 29, 2024
| LONGNAME=%{name} \ | ||
| PKGNAME=%{name} \ | ||
| VERSION=%{version} | ||
| %meson "-Dgobuildflags=%buildflags" %ldflags |
There was a problem hiding this comment.
Is it really correct to pass the ldflags to meson? Looks like all versions don't like that. https://docs.fedoraproject.org/en-US/packaging-guidelines/Meson/ suggests that normally it should be able to figure it out by default.
ekohl
reviewed
Aug 29, 2024
There was a problem hiding this comment.
yggdrasil 0.4.1 is in centos-stream 9 at least. If we don't make any modifications, I'd prefer to rely on that once RHEL 9.5 comes out. As for EL 7 & 8: I wouldn't mind keeping them on older versions.
In our package manifest and comps files we can tell the build system to only build for EL 7, 8 and OpenSUSE.
by pulling in the spec from CS9[1]. [1] - https://gitlab.com/redhat/centos-stream/rpms/yggdrasil/-/blob/63eb41286348fd7888db0005db603cbb85670370/yggdrasil.spec
adamruzicka
force-pushed
the
rpm/develop-ygg-0.4.z
branch
from
c89808c
to
d89862d
Compare
Just want to get the lints out of the way to see if this would work on different distributions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's see what happens