Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move some ansible-free code to apypie #1789

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

move some ansible-free code to apypie #1789

wants to merge 1 commit into from

Conversation

evgeni
Copy link
Member

@evgeni evgeni commented Oct 28, 2024

No description provided.

@evgeni evgeni force-pushed the the-refactoring branch 9 times, most recently from 4e78098 to 9a2b637 Compare October 28, 2024 11:49
@evgeni evgeni mentioned this pull request Oct 28, 2024
Open
@evgeni evgeni force-pushed the the-refactoring branch 2 times, most recently from 3dd17c4 to ef6595f Compare October 28, 2024 12:44
ekohl
ekohl reviewed Oct 28, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider this some of the notes I made while reading this. I realize it's very much a work in progress and should result in a real PR to apypie itself before updating the vendored copy.

plugins/module_utils/_apypie.py Outdated Show resolved Hide resolved
plugins/module_utils/foreman_helper.py Show resolved Hide resolved
plugins/module_utils/_apypie.py Outdated Show resolved Hide resolved
plugins/module_utils/foreman_helper.py Outdated Show resolved Hide resolved
@evgeni evgeni force-pushed the the-refactoring branch 4 times, most recently from 8121f36 to 9adb24b Compare October 30, 2024 09:27
@evgeni evgeni force-pushed the the-refactoring branch 2 times, most recently from 2542b8e to 121fa6c Compare November 19, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgeni @ekohl