ci: enhanced linting #158
Merged
ci: enhanced linting #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should only be merged after #141 which refactors and fixes all the linting issues. |
stevenh
force-pushed
the
ci/enhanced-linting
branch
from
4412164
to
df785fe
Compare
Add a configuration file which makes it much more strict. Fix shadowed error variables flagged by linter. Remove CI timeout as its now present in the config.
stevenh
force-pushed
the
ci/enhanced-linting
branch
from
df785fe
to
adbf57f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration file which makes it much more strict.
Fix shadowed error variables flagged by linter.
Remove CI timeout as its now present in the config.