Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shutdown race resilience #141

Merged
merged 1 commit into from
Oct 7, 2024

Commits on Oct 4, 2024

  1. feat: shutdown race resilience

    A significant rewrite to ensure that we don't suffer from shutdown race
    conditions as the prune condition is met and additional resources are
    being created.
    
    Previously this would remove resources that were still in use, now we
    retry if we detect new resources have been created within a window of
    the prune condition triggering.
    
    This supports the following new environment configuration settings:
    - RYUK_REMOVE_RETRIES - The number of times to retry removing a resource.
    - RYUK_REQUEST_TIMEOUT - The timeout for any Docker requests.
    - RYUK_RETRY_OFFSET - The offset added to the start time of the prune
      pass that is used as the minimum resource creation time.
    - RYUK_SHUTDOWN_TIMEOUT - The duration after shutdown has been requested
      when the remaining connections are ignored and prune checks start.
    
    Update README to correct example, as health is only valid for containers
    not the other resources, so would cause failures.
    
    Enable race detection on CI tests.
    stevenh committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    01bc3c8 View commit details
    Browse the repository at this point in the history