Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team DelSquared (RGSoC '18): Added Hello World tutorial for Windows 10 #29

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

arushi019
Copy link

Hi!

I have added the hello world tutorial for Windows 10 in reach-wg/tutorials/ folder. Kindly review @Frijol
Issue: #27
Thanks :)

Frijol
Frijol previously requested changes Aug 22, 2018
Copy link
Member

@Frijol Frijol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's coming across a bit hard to read:

screen shot 2018-08-22 at 4 11 39 pm

Would you please update the file to make it more readable? Ideally it would be a Markdown file, but a cleaner PDF would be ok.

@arushi019
Copy link
Author

arushi019 commented Aug 29, 2018

Hi @Frijol ! I have made a new esp32_blogpost.md in markdown format. Kindly review the PR :)

Copy link

@HipsterBrown HipsterBrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content is great. 😄 I added a few comments of feedback before merging.


We’re currently aiming to make our contribution to the Tessel project. Tessel-Reach is a developing concept that we
recently got introduced to.<br>
It aims at creating a star topology network with a Tessel 2 board as the hub and Reach modules as low power nodes,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link "star topology network" to a definition of that concept?

It aims at creating a star topology network with a Tessel 2 board as the hub and Reach modules as low power nodes,
that are currently being configured on an ESP32 Thing.<br>
The latest development on this project was to push a hello world program onto the firmware of ESP32. We began
by achieving the same, while following the ESP-IDF tutorial, in order to familiarise ourselves with the

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link "ESP-IDF tutorial" to that tutorial website?

with the sensor i.e. push code to the sensor and make it do some exciting stuff :D<br>
Here’s how we went about it...<br>
## Step 1
We kick-started the process by setting up the toolchain for the ESP32 module. This took about an hour — first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the toolchain? Can you link to it? Or be more specific?

to the esp folder but it worked only with the esp-idf folder. The path given on the website did not work.<br>
(/img/esp2.png)
## Step 3
We then gave the make menuconfig command and selected the serial flash option. Following that, we selected the default

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add quotes ("") or backticks (``) around the make commands so they are easier to read?

@HipsterBrown HipsterBrown dismissed Frijol’s stale review September 7, 2018 17:12

It has been fixed by the team.

Copy link
Member

@Frijol Frijol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits! I second @HipsterBrown's comments and added a couple of my own. Can you also please remove the PDF file from the commit (assuming it is now redundant)?

---

We’re currently aiming to make our contribution to the Tessel project. Tessel-Reach is a developing concept that we
recently got introduced to.<br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In markdown, you should do two carriage returns to demarcate paragraphs, instead of the <br> html syntax

‘esp-idf’ folder in esp.<br>
(/img/esp1.png)
## Step 2
The hello world folder loaded into the msys32 folder. We had to the set IDF_PATH correctly. It was initially set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the hello world folder? Is there a link someone could use to replicate?

@Frijol
Copy link
Member

Frijol commented Sep 12, 2018

By the way, if the two of you want to share who gets credit for commits in git, you might like this tool: https://github.com/peterjwest/git-pair :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants