Fix 10s minimum time for cache restores #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
listObjects caused the cache restore to take a minimum of 10 seconds because the timeout was not cleared when the Promise is resolved or rejected.
|
The change looks good to me. But I wonder why it worked before.... |
|
Thanks for the merge and release @jackieli-tes Do you use this action with ARC or something else? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We saw that every cache restore seems to take a minimum of 10s even for small 1MB caches from a local network using Minio or Seaweedfs.
The cause seems to be the
listObjectsfunction. It starts a timeout of 10s that is not cleared when the Promise is resolved or rejected. This causes the action to hang for a minimum of 10s even when the restore was faster.Before fix:
After fix:
Changes
listObjectswhen the Promise is resolved or rejected.Fix Issues
Fixes #43