Add WorkflowUpdateResultException
#526
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
|
@roxblnfk So I think we don't need to do this at all - in the other SDKs we just keep trying until we hit the timeout or are cancelled and we should mirror that behavior here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added the
WorkflowUpdateResultException, which is thrown byUpdateHandle->getResult()when a Workflow Update Request is stuck in the ADMITTED status. This situation can occur when the Workflow neither accepts nor rejects the Update due to:Why?
Developers need to distinguish between
nullas an actual result of a Workflow Update action and "no result."Prior to this patch, the code used
assert($result === null), which did not align with reality. Additionally, assertions are typically disabled in production environments.Checklist
Closes
How was this tested: