-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #866
Conversation
…16-rate-limiting-issue-on-holders-view
…ong-before-showing-some-feedback #858 | The address page now shows feedback immediately
…-contract-should-handle-tuple-parameters-for-contracts-that-require-them #487 | teloscan read and write contract should handle tuple parameters for contracts that require them
…holders-view-2 #816 | change the strategy to only fetch contracts from cache
✅ Deploy Preview for dev-mainnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testnet-teloscan ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teloscan-stage ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is good here
Fixes #487 #816 #858
Description
This PR merges three previously validated features from development into master:
Contract Parameter Enhancement (!#487 | teloscan read and write contract should handle tuple parameters for contracts that require them #863):
Contract Cache Optimization (!#816 | change the strategy to only fetch contracts from cache #850):
Address Page UX Improvements (!#858 | The address page now shows feedback immediately #859):
Test scenarios
1. Contract Parameter Testing
[123, "0xA1F2aDC12cdB069406BFe51f31980324d757317C", false]
2. Cache Implementation Testing
https://deploy-preview-850--dev-mainnet-teloscan.netlify.app/address/0x975Ed13fa16857E83e7C493C7741D556eaaD4A3f
3. Address Page Responsiveness