Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #866

Merged
merged 11 commits into from
Oct 29, 2024
Merged

Dev #866

merged 11 commits into from
Oct 29, 2024

Conversation

pmjanus
Copy link
Contributor

@pmjanus pmjanus commented Oct 28, 2024

Fixes #487 #816 #858

Description

This PR merges three previously validated features from development into master:

  1. Contract Parameter Enhancement (!#487 | teloscan read and write contract should handle tuple parameters for contracts that require them #863):

    • Added support for tuple and tuple array parameters in contract interactions
    • Implemented JSON array format for complex parameter input
    • Users can now interact with contracts requiring structured data types
  2. Contract Cache Optimization (!#816 | change the strategy to only fetch contracts from cache #850):

    • Improved performance by fetching contract metadata exclusively from cache
    • Delegated cache population responsibility to indexer API
    • Eliminated redundant API calls in holders view
  3. Address Page UX Improvements (!#858 | The address page now shows feedback immediately #859):

    • Implemented immediate visual feedback on address page loads
    • Added loading skeletons and spinners for better user experience
    • Optimized component layout for progressive content loading

Test scenarios

1. Contract Parameter Testing

  1. Navigate to Example Contract in Write section
  2. Test tuple parameter input using array format:

[123, "0xA1F2aDC12cdB069406BFe51f31980324d757317C", false]

  1. Verify successful contract interaction with complex parameters

2. Cache Implementation Testing

  1. Visit USDT holders page at:
    https://deploy-preview-850--dev-mainnet-teloscan.netlify.app/address/0x975Ed13fa16857E83e7C493C7741D556eaaD4A3f
  2. Open developer tools (F12) -> Network tab
  3. Clear network logs
  4. Navigate to Holders tab
  5. Verify no additional queries for address metadata
  6. Test through multiple pages to confirm no extra queries

3. Address Page Responsiveness

  1. Visit any address page
  2. Confirm immediate page structure loading
  3. Verify loading spinner appears next to address while determining type
  4. Check that "more-info" cards properly utilize available space during loading
  5. Validate skeleton loading patterns across all sections

Viterbo and others added 11 commits August 14, 2024 14:50
…ong-before-showing-some-feedback

#858 | The address page now shows feedback immediately
…-contract-should-handle-tuple-parameters-for-contracts-that-require-them

#487 | teloscan read and write contract should handle tuple parameters for contracts that require them
…holders-view-2

#816 | change the strategy to only fetch contracts from cache
@pmjanus pmjanus requested a review from Viterbo October 28, 2024 20:18
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit a7e267f
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/671ff1967a5dfc0008b442f5
😎 Deploy Preview https://deploy-preview-866--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for teloscan ready!

Name Link
🔨 Latest commit a7e267f
🔍 Latest deploy log https://app.netlify.com/sites/teloscan/deploys/671ff196f014650007454788
😎 Deploy Preview https://deploy-preview-866--teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit a7e267f
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/671ff196bee54d000870e751
😎 Deploy Preview https://deploy-preview-866--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit a7e267f
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/671ff196f01465000745478a
😎 Deploy Preview https://deploy-preview-866--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Viterbo Viterbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is good here

@Viterbo Viterbo merged commit 6de7707 into master Oct 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teloscan read and write contract should handle tuple parameters for contracts that require them.
2 participants