-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
access to id, service and subservice in jexl context for functional test #1636
access to id, service and subservice in jexl context for functional test #1636
Conversation
test/functional/testCases.js
Outdated
@@ -1785,7 +1784,7 @@ const testCases = [ | |||
object_id: 'a', | |||
name: 'attr_a', | |||
type: 'Text', | |||
expression: 'a+":"+service+subservice+id+type' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
groupToIoTAConfigType is not providen deviceId
Maybe testUtils.testCase should do that
I think it would be wise to use same literals than the one used at CB (https://github.com/telefonicaid/fiware-orion/blob/master/doc/manuals/orion-api.md#macro-substitution)
Is the PR working that way? |
Not. This is just to align functional tests with implemented feature in iotagent-node-lib, specially test about jexl context |
CB uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fix for #1523