Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed for the issue #1524 #1611

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vivekNEC
Copy link

fixed #1524

@AlvaroVega
Copy link
Member

AlvaroVega commented May 16, 2024

@vivekNEC Thanks for your great contribution.
I would like this PR should contain a tests (maybe a functional test) which raises the bug and then show how this PR is fixing the bug.
Maybe @Madhu-NEC could contribute it

@fgalan
Copy link
Member

fgalan commented May 16, 2024

In addition to @AlvaroVega comment, please add an entry in CHANGES_NEXT_RELEASES describing the fix done by this PR. Suggestion:

- Fix: autoprovison now working with resources diferent from defaultResource (#1524)

@vivekNEC
Copy link
Author

Hi @AlvaroVega is there any existing test cases related to service autoprovision that I could use as a reference. If there are any, could you please point me in the right direction?

@mapedraza
Copy link
Collaborator

Hi @AlvaroVega is there any existing test cases related to service autoprovision that I could use as a reference. If there are any, could you please point me in the right direction?

If you find in the repo you will find several examples like the following one:

describe('When the IoT Agent receives autoprovisioned id and type measures', function () {

@AlvaroVega
Copy link
Member

Hi @AlvaroVega is there any existing test cases related to service autoprovision that I could use as a reference. If there are any, could you please point me in the right direction?

I was thinking about something like

describeName: '0020 - Simple group with active attributes',

@vivekNEC
Copy link
Author

Hi @AlvaroVega
I checked all the functional tests you shared, but none seem related to that bug fix. Please let me know if I'm mistaken

@@ -0,0 +1,2 @@
- Fix: default express limit to 1Mb instead default 100Kb and allow change it throught a conf env var 'IOTA_EXPRESS_LIMIT' (telefonicaid/iotagent-json#827)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already included in https://github.com/telefonicaid/iotagent-node-lib/releases/tag/4.5.0 (I think it's here due to some mistake in github conflict resolution)

Suggested change
- Fix: default express limit to 1Mb instead default 100Kb and allow change it throught a conf env var 'IOTA_EXPRESS_LIMIT' (telefonicaid/iotagent-json#827)

@AlvaroVega
Copy link
Member

Hi @AlvaroVega I checked all the functional tests you shared, but none seem related to that bug fix. Please let me know if I'm mistaken

There are other options to make tests as were described in: #1611 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoprovison only works with the defined defaultResource
4 participants