-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed for the issue #1524 #1611
base: master
Are you sure you want to change the base?
Conversation
@vivekNEC Thanks for your great contribution. |
In addition to @AlvaroVega comment, please add an entry in CHANGES_NEXT_RELEASES describing the fix done by this PR. Suggestion:
|
Hi @AlvaroVega is there any existing test cases related to service autoprovision that I could use as a reference. If there are any, could you please point me in the right direction? |
If you find in the repo you will find several examples like the following one:
|
I was thinking about something like
|
Hi @AlvaroVega |
CHANGES_NEXT_RELEASE
Outdated
@@ -0,0 +1,2 @@ | |||
- Fix: default express limit to 1Mb instead default 100Kb and allow change it throught a conf env var 'IOTA_EXPRESS_LIMIT' (telefonicaid/iotagent-json#827) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already included in https://github.com/telefonicaid/iotagent-node-lib/releases/tag/4.5.0 (I think it's here due to some mistake in github conflict resolution)
- Fix: default express limit to 1Mb instead default 100Kb and allow change it throught a conf env var 'IOTA_EXPRESS_LIMIT' (telefonicaid/iotagent-json#827) |
There are other options to make tests as were described in: #1611 (comment) |
fixed #1524