Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the whole documentation in order to remove deprecated / removed features #1437

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Review the whole documentation in order to remove deprecated / removed features #1437

merged 5 commits into from
Sep 11, 2023

Conversation

mapedraza
Copy link
Collaborator

@mapedraza mapedraza commented Sep 7, 2023 •
edited by fgalan
Loading

Issue #1329

  • References to "plugin" (and its variant "plug-in") 10aa0b4
  • References to "bidirectional" (deprecated feature) - No references found
  • References to "appendMode" and "IOTA_APPEND_MODE" (and its variants "append" and "APPEND") (deprecated feature) 7b50a96
  • References to "legacy" and " expressionLanguage" (legacy expressions) eea68d8

@mapedraza mapedraza changed the base branch from master to task/doc-rework September 7, 2023 13:50
@mapedraza
Copy link
Collaborator Author

mapedraza commented Sep 7, 2023 •
edited
Loading

Remaining plugin references:

https://www.github.com/telefonicaid/iotagent-node-lib/blob/task/doc-rework-removed-deprecated/doc/admin.md#L327-L329

removed at b3c1ed6

@mapedraza mapedraza mentioned this pull request Sep 7, 2023
Open
25 tasks
@mapedraza
Copy link
Collaborator Author

mapedraza commented Sep 7, 2023 •
edited
Loading

Remaining append mode references:

Since only append mode now is used (thus, this flag now is removed). Probably changing every reference into the doc from "update" to append makes sense

Done here: 4c0b7ce

@mapedraza
Copy link
Collaborator Author

Remaining plugin references:

https://www.github.com/telefonicaid/iotagent-node-lib/blob/task/doc-rework-removed-deprecated/doc/admin.md#L327-L329

This should be clarified in further steps

NTC

@mapedraza
Copy link
Collaborator Author

This PR is ready to review

@fgalan fgalan mentioned this pull request Sep 11, 2023
Merged
fgalan
fgalan approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@fgalan fgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fgalan fgalan merged commit 653fb28 into task/doc-rework Sep 11, 2023
@fgalan fgalan deleted the task/doc-rework-removed-deprecated branch September 11, 2023 09:23
@fgalan fgalan mentioned this pull request Sep 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fgalan fgalan fgalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mapedraza @fgalan