Merge pull request #1411 from telefonicaid/task/do_not_create_initial…

…_entity update tests
telefonicaid · Aug 10, 2023 · 4d7c824 · 4d7c824
2 parents 9383b76 + 01955d4
commit 4d7c824
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 15 deletions.
diff --git a/test/unit/ngsiv2/provisioning/device-update-registration_test.js b/test/unit/ngsiv2/provisioning/device-update-registration_test.js
@@ -148,15 +148,6 @@ describe('NGSI-v2 - IoT Agent Device Update Registration', function () {
             .post('/v2/registrations')
             .reply(201, null, { Location: '/v2/registrations/6319a7f5254b05844116584d' });
 
-        // This mock does not check the payload since the aim of the test is not to verify
-        // device provisioning functionality. Appropriate verification is done in tests under
-        // provisioning folder
-        contextBrokerMock
-            .matchHeader('fiware-service', 'smartgondor')
-            .matchHeader('fiware-servicepath', 'gardens')
-            .post('/v2/entities?options=upsert')
-            .reply(204);
-
         iotAgentLib.activate(iotAgentConfig, function (error) {
             iotAgentLib.register(device1, function (error) {
                 done();
@@ -205,6 +196,14 @@ describe('NGSI-v2 - IoT Agent Device Update Registration', function () {
                 .reply(201, null, { Location: '/v2/registrations/6319a7f5254b05844116584d' });
         });
 
+        it('should register as ContextProvider of its lazy attributes', function (done) {
+            iotAgentLib.updateRegister(deviceUpdated, false, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+
         it('should store the new values in the registry', function (done) {
             iotAgentLib.updateRegister(deviceUpdated, false, function (error, data) {
                 iotAgentLib.getDevice(deviceUpdated.id, 'smartgondor', 'gardens', function (error, deviceResult) {
@@ -253,6 +252,14 @@ describe('NGSI-v2 - IoT Agent Device Update Registration', function () {
                 .reply(201, null, { Location: '/v2/registrations/6319a7f5254b05844116584d' });
         });
 
+        it('should register as ContextProvider of its commands and create the additional attributes', function (done) {
+            iotAgentLib.updateRegister(deviceCommandUpdated, false, function (error) {
+                should.not.exist(error);
+                contextBrokerMock.done();
+                done();
+            });
+        });
+
         it('should store the new values in the registry', function (done) {
             iotAgentLib.updateRegister(deviceCommandUpdated, false, function (error, data) {
                 iotAgentLib.getDevice(

diff --git a/test/unit/plugins/capture-provision-inPlugins_test.js b/test/unit/plugins/capture-provision-inPlugins_test.js
@@ -89,12 +89,6 @@ describe('NGSI-v2 - Data Mapping Plugins: device provision', function () {
             )
             .reply(201, null, { Location: '/v2/registrations/6319a7f5254b05844116584d' });
 
-        contextBrokerMock
-            .matchHeader('fiware-service', 'smartgondor')
-            .matchHeader('fiware-servicepath', '/gardens')
-            .post('/v2/entities?options=upsert')
-            .reply(204);
-
         iotAgentLib.activate(iotAgentConfig, function (error) {
             iotAgentLib.clearAll(done);
         });
@@ -124,6 +118,18 @@ describe('NGSI-v2 - Data Mapping Plugins: device provision', function () {
             });
         });
 
+        it('should continue with the registration process', function (done) {
+            function testMiddleware(device, callback) {
+                callback(null, device);
+            }
+
+            iotAgentLib.addDeviceProvisionMiddleware(testMiddleware);
+
+            request(options, function (error, response, body) {
+                contextBrokerMock.done();
+                done();
+            });
+        });
 
         it('should execute the device provisioning handlers', function (done) {
             let executed = false;