feat: add databaseMirroringPartner event handler
#1671
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-w-nick
commented
Oct 31, 2024
Comment on lines
365
to
366
| } | ||
|
|
||
| onDatabaseMirroringPartner(token: DatabaseMirroringPartnerEnvChangeToken) { | ||
| // Do nothing | ||
| } | ||
| } |
There was a problem hiding this comment.
I moved this handler to be right below the onDatabaseChange event handler for better ordering and to keep the event next to all of the other ENVCHANGE events.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1671 +/- ##
==========================================
- Coverage 78.81% 78.80% -0.02%
==========================================
Files 90 90
Lines 4877 4878 +1
Branches 918 918
==========================================
Hits 3844 3844
- Misses 735 736 +1
Partials 298 298 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix #1669, where the library throws an unhandled exception if it encounters an
ENVCHANGEevent of typeDATABASE_MIRRORING_PARTNER.This behavior isn't explicitly documented, but there have been a few issues brought up regarding this functionality in the past, and it has been stated that tedious does not plan to support failover partners. While that may be the case, this event being emitted by SQL Server is causing Tedious to crash completely rather than simply ignoring it as you would expect.
The changes in this PR are to create the
databaseMirroringPartnerevent emitter and register the necessary handler methods in the associated token handler classes, to prevent the default behavior of throwing anUnexpected tokenerror.To clarify, this does not implement mirroring functionality or anything of the sort, it simply updates the default behavior to allow the event to pass through and be ignored, rather than unnecessarily throwing an unhandled exception.