Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partial tests for import defer #4278

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Commits on Oct 25, 2024

  1. Add partial tests for import defer

    - syntax
    - Deferred namespace objects
    - Behavior of synchronous deferred modules
    - Errors for synchronous cases
    
    I will open another PR (or push another commit here) for tests about
    async modules, since I still have to finish polishing it up.
    
    There are a few details of the proposal that are still in flux because
    of some bugs, so this PR does not include tests for them:
    - `Symbol.toStringTag` of deferred namespace objects
    - `test/language/import/import-defer/evaluation-sync/evaluation-*` for the other object operations
    - `import.defer`, which currently doesn't actually defer due to a problem with `.then`
    nicolo-ribaudo committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    fda523d View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2024

  1. Fixes for import-defer tests

      * Add deepEqual.js include where needed
      * Add module flag where needed
      * Fix some typos
      * In evaluation-ignore-set, add a try block to catch typeerrors from assignment
    
    Need the bug URL (OOPS!).
    
    Reviewed by NOBODY (OOPS!).
    
    Explanation of why this fixes the bug (OOPS!).
    
    * test/language/import/import-defer/deferred-namespace-object/dep-defer-ns_FIXTURE.js:
    * test/language/import/import-defer/deferred-namespace-object/identity.js:
    * test/language/import/import-defer/deferred-namespace-object/object-properties.js:
    * test/language/import/import-defer/errors/get-other-while-dep-evaluating/main.js:
    * test/language/import/import-defer/errors/get-other-while-evaluating/main.js:
    * test/language/import/import-defer/errors/get-self-while-defer-evaluating/main.js:
    * test/language/import/import-defer/errors/get-self-while-evaluating.js:
    * test/language/import/import-defer/errors/module-throws/defer-import-after-evaluation.js:
    * test/language/import/import-defer/errors/module-throws/third-party-evaluation-after-defer-import.js:
    * test/language/import/import-defer/errors/module-throws/trigger-evaluation.js:
    * test/language/import/import-defer/errors/resolution-error/import-defer-of-syntax-error-fails.js:
    * test/language/import/import-defer/errors/syntax-error/import-defer-of-syntax-error-fails.js:
    * test/language/import/import-defer/evaluation-sync/evaluation-ignore-get-symbol.js:
    * test/language/import/import-defer/evaluation-sync/evaluation-ignore-getPrototypeOf.js:
    * test/language/import/import-defer/evaluation-sync/evaluation-ignore-isExtensible.js:
    * test/language/import/import-defer/evaluation-sync/evaluation-ignore-preventExtensions.js:
    * test/language/import/import-defer/evaluation-sync/evaluation-ignore-set.js:
    * test/language/import/import-defer/evaluation-sync/evaluation-ignore-setPrototypeOf.js:
    * test/language/import/import-defer/evaluation-sync/evaluation-trigger-get-string.js:
    * test/language/import/import-defer/evaluation-sync/import-defer-does-not-evaluate.js:
    * test/language/import/import-defer/evaluation-sync/module-imported-defer-and-eager.js:
    * test/language/import/import-defer/syntax/import-attributes.js:
    * test/language/import/import-defer/syntax/valid-default-binding-named-defer.js:
    * test/language/import/import-defer/syntax/valid-defer-namespace.js:
    takikawa authored and nicolo-ribaudo committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    79c364c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8ab7c25 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Configuration menu
    Copy the full SHA
    d5ea87e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fe7a185 View commit details
    Browse the repository at this point in the history
  3. Fix wrong descriptions

    nicolo-ribaudo committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fe5db3c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0e5df8b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    612c920 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Configuration menu
    Copy the full SHA
    af3d19b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    acd2924 View commit details
    Browse the repository at this point in the history
  3. Lint

    nicolo-ribaudo committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a873634 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Configuration menu
    Copy the full SHA
    75a6e1c View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. More fixes

    nicolo-ribaudo committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    2e0982e View commit details
    Browse the repository at this point in the history