-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partial tests for import defer
#4278
Open
nicolo-ribaudo
wants to merge
13
commits into
tc39:main
Choose a base branch
from
nicolo-ribaudo:import-defer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 25, 2024
-
Add partial tests for
import defer
- syntax - Deferred namespace objects - Behavior of synchronous deferred modules - Errors for synchronous cases I will open another PR (or push another commit here) for tests about async modules, since I still have to finish polishing it up. There are a few details of the proposal that are still in flux because of some bugs, so this PR does not include tests for them: - `Symbol.toStringTag` of deferred namespace objects - `test/language/import/import-defer/evaluation-sync/evaluation-*` for the other object operations - `import.defer`, which currently doesn't actually defer due to a problem with `.then`
Configuration menu - View commit details
-
Copy full SHA for fda523d - Browse repository at this point
Copy the full SHA fda523dView commit details
Commits on Oct 28, 2024
-
* Add deepEqual.js include where needed * Add module flag where needed * Fix some typos * In evaluation-ignore-set, add a try block to catch typeerrors from assignment Need the bug URL (OOPS!). Reviewed by NOBODY (OOPS!). Explanation of why this fixes the bug (OOPS!). * test/language/import/import-defer/deferred-namespace-object/dep-defer-ns_FIXTURE.js: * test/language/import/import-defer/deferred-namespace-object/identity.js: * test/language/import/import-defer/deferred-namespace-object/object-properties.js: * test/language/import/import-defer/errors/get-other-while-dep-evaluating/main.js: * test/language/import/import-defer/errors/get-other-while-evaluating/main.js: * test/language/import/import-defer/errors/get-self-while-defer-evaluating/main.js: * test/language/import/import-defer/errors/get-self-while-evaluating.js: * test/language/import/import-defer/errors/module-throws/defer-import-after-evaluation.js: * test/language/import/import-defer/errors/module-throws/third-party-evaluation-after-defer-import.js: * test/language/import/import-defer/errors/module-throws/trigger-evaluation.js: * test/language/import/import-defer/errors/resolution-error/import-defer-of-syntax-error-fails.js: * test/language/import/import-defer/errors/syntax-error/import-defer-of-syntax-error-fails.js: * test/language/import/import-defer/evaluation-sync/evaluation-ignore-get-symbol.js: * test/language/import/import-defer/evaluation-sync/evaluation-ignore-getPrototypeOf.js: * test/language/import/import-defer/evaluation-sync/evaluation-ignore-isExtensible.js: * test/language/import/import-defer/evaluation-sync/evaluation-ignore-preventExtensions.js: * test/language/import/import-defer/evaluation-sync/evaluation-ignore-set.js: * test/language/import/import-defer/evaluation-sync/evaluation-ignore-setPrototypeOf.js: * test/language/import/import-defer/evaluation-sync/evaluation-trigger-get-string.js: * test/language/import/import-defer/evaluation-sync/import-defer-does-not-evaluate.js: * test/language/import/import-defer/evaluation-sync/module-imported-defer-and-eager.js: * test/language/import/import-defer/syntax/import-attributes.js: * test/language/import/import-defer/syntax/valid-default-binding-named-defer.js: * test/language/import/import-defer/syntax/valid-defer-namespace.js:
Configuration menu - View commit details
-
Copy full SHA for 79c364c - Browse repository at this point
Copy the full SHA 79c364cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ab7c25 - Browse repository at this point
Copy the full SHA 8ab7c25View commit details
Commits on Oct 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d5ea87e - Browse repository at this point
Copy the full SHA d5ea87eView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe7a185 - Browse repository at this point
Copy the full SHA fe7a185View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe5db3c - Browse repository at this point
Copy the full SHA fe5db3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e5df8b - Browse repository at this point
Copy the full SHA 0e5df8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 612c920 - Browse repository at this point
Copy the full SHA 612c920View commit details
Commits on Nov 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for af3d19b - Browse repository at this point
Copy the full SHA af3d19bView commit details -
Configuration menu - View commit details
-
Copy full SHA for acd2924 - Browse repository at this point
Copy the full SHA acd2924View commit details -
Configuration menu - View commit details
-
Copy full SHA for a873634 - Browse repository at this point
Copy the full SHA a873634View commit details
Commits on Nov 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 75a6e1c - Browse repository at this point
Copy the full SHA 75a6e1cView commit details
Commits on Nov 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2e0982e - Browse repository at this point
Copy the full SHA 2e0982eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.