Add implementation guide #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #9
ljharb
requested changes
May 22, 2018
implement.md
Outdated
|
|
||
| TC39 appreciates implementers! In addition to getting features to JS developers, the process of implementation gives detailed sense of the feature within the language as a whole and its various interactions, leading to important insights about the design. | ||
|
|
||
| ll kinds of feedback are appreciated from implementers, whether it's about the motivation, high-level design, integration with various other systems, implementation complexity, or the semantics of edge cases. The best way to give feedback is through filing bugs in the GitHub repository. Feel free to make PRs against the draft spec for suggested semantic changes, as well. |
There was a problem hiding this comment.
also, "in the GitHub repository for the proposal" - ie, not in ecma262
- Eliminate link to .babelrc - s/ll/All/ - Clarify PRs welcome against proposal repo
gsathya
reviewed
May 25, 2018
implement.md
Outdated
|
|
||
| At Stage 0, 1 and 2, semantic details are up in the air. The committee has not come to consensus on all of the concrete details of the proposal. Implementations at this stage should be considered experimental and speculative. Implementations at this stage can be very valuable to enable experimentation by programmers, which can help refine the language design. Implementations tend to expose this stage of feature via special flags which are not enabled by default. | ||
|
|
||
| ### Case studies |
There was a problem hiding this comment.
I'm ok with saying what you say about V8, but don't feel comfortable signing off for other engines here. Especially since this is incorrect: JSC and ChakraCore ship dynamic import which is Stage 3. I would just remove this section entirely, since it doesn't add as much value as the other sections.
There was a problem hiding this comment.
Thanks for the review; removed the section.
gsathya
approved these changes
May 26, 2018
|
Thanks! |
|
OK, feedback has been addressed, so landing this PR. If you have any other concerns, let's fix them in a follow-on patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
cc @gsathya