fix: inherit icon_is_template in set_icon #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrbashir
requested changes
Nov 12, 2024
There was a problem hiding this comment.
set_icon_as_template was provided separately because it doesn't exist on other operating systems, this also doesn't fix usage DX that much because if you need to set a normal icon, you will have to
tray.set_icon_as_template(false);
tray.set_icon(new_icon);which IMO is worse than current API and counter-intutive.
I think we can instead add set_icon_with_as_template or something that allows the caller to specify both,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #203
I am not sure this is correct in 100% cases but it feels more natural that when you change the icon you want the similar settings for its
icon_is_templatevalue.