-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare-workspace: make an empty commit for actions/checkout #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickVolynkin
force-pushed
the
nickvolynkin/cleanup-with-empty-commit
branch
from
November 10, 2022 10:42
0f14e8d
to
8e2b4c8
Compare
NickVolynkin
force-pushed
the
nickvolynkin/cleanup-with-empty-commit
branch
from
November 10, 2022 11:02
8e2b4c8
to
83ea8fe
Compare
ylobankov
reviewed
Nov 10, 2022
Honestly, your change looks like a separate action that should be named |
NickVolynkin
force-pushed
the
nickvolynkin/cleanup-with-empty-commit
branch
from
November 10, 2022 12:32
83ea8fe
to
0c91fb7
Compare
NickVolynkin
force-pushed
the
nickvolynkin/cleanup-with-empty-commit
branch
5 times, most recently
from
November 10, 2022 13:26
1297063
to
c4339de
Compare
ylobankov
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Make an empty detached commit for actions/checkout to properly clean the project's workspace before checking out new code revision. It makes the actions/checkout resilient to various problems related to git submodules. Part of #28 Related to tarantool/tarantool-qa#145
NickVolynkin
force-pushed
the
nickvolynkin/cleanup-with-empty-commit
branch
from
November 10, 2022 13:32
c4339de
to
ba2fcf5
Compare
ylobankov
changed the title
cleanup: make an empty commit for actions/checkout
prepare-workspace: make an empty commit for actions/checkout
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make an empty detached commit for actions/checkout to properly clean the project's workspace before checking out new code revision.
Part of #28
Related to tarantool/tarantool-qa#145
Readme preview: https://github.com/tarantool/actions/blob/nickvolynkin/cleanup-with-empty-commit/prepare-checkout/README.md