Fix handling of node-format
when output-format-type
is set
#38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior is that if
output-format-type
is setnode-format
isignored. This includes the case where
output-format-type
is set in aconfig file, so if your config file sets a default format it's
impossible to override it on the command line.
One solution is to avoid setting a default output format in config
files. While that works, it's worth noting unidic-mecab's default config
file includes a default output format. If someone tries to use
node-format
without being aware of this they might just think it doesn'twork.
This change makes it so that if
node-format
is explicitly setoutput-format-type
is ignored. Ifoutput-format-type
isn't used behavioris unchanged; this only changes things when
output-format-type
andnode-format
are both set. -POLM