Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of node-format when output-format-type is set #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

polm
Copy link

@polm polm commented Aug 1, 2017

Current behavior is that if output-format-type is set node-format is
ignored. This includes the case where output-format-type is set in a
config file, so if your config file sets a default format it's
impossible to override it on the command line.

One solution is to avoid setting a default output format in config
files. While that works, it's worth noting unidic-mecab's default config
file includes a default output format. If someone tries to use
node-format without being aware of this they might just think it doesn't
work.

This change makes it so that if node-format is explicitly set
output-format-type is ignored. If output-format-type isn't used behavior
is unchanged; this only changes things when output-format-type and
node-format are both set. -POLM

Current behavior is that if output-format-type is set node-format is
ignored. This includes the case where output-format-type is set in a
config file, so if your config file sets a default format it's
impossible to override it on the command line.

One solution is to avoid setting a default output format in config
files. While that works, it's worth noting unidic-mecab's default config
file includes a default output format. If someone tries to use
node-format without being aware of this they might just think it doesn't
work.

This change makes it so that if node-format is explicitly set
output-format-type is ignored. If output-format-type isn't used behavior
is unchanged; this only changes things when output-format-type and
node-format are both set. -POLM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant