-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT-1236] Add Card Variants to Storybook #1262
base: develop
Are you sure you want to change the base?
[FEAT-1236] Add Card Variants to Storybook #1262
Conversation
A little unclear about these props ( pill, size, state ) @AllieMendes can you help me with this? |
Sorry for the delay @ManishBisht777, didn't see this. The pill is a toggleable element, I recommend using the Dev Mode playground to test the components and what each property does: Here is an example of where it's used: The size is outdated, it seems, and the hover state is missing (but the property should exist). If I take too long to answer, don't hesitate to ping me on Figma as it's easier for me to keep track of the conversation! |
got it, thanks allie🚀 |
No worries, let me know if you have any other questions :) |
Hey @ManishBisht777 how are we doing here, do you need any help or is this PR waiting for review ? |
hey @AvineshTripathi sorry completely forgot about this pr will will get back to in some time, sorry for the delay |
@ManishBisht777 status check |
Fixes: #1236
Changes Made
Screenshots
Checklist
Reviewers
@[username of the reviewer]