Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT-1236] Add Card Variants to Storybook #1262

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

ManishBisht777
Copy link
Contributor

Fixes: #1236

Changes Made

  • Add stories for card
  • Created Components to match Figma
  • Added tests

Screenshots

image
image

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@ManishBisht777
Copy link
Contributor Author

A little unclear about these props ( pill, size, state )

@AllieMendes can you help me with this?

image

@ManishBisht777 ManishBisht777 marked this pull request as ready for review December 6, 2023 11:33
@AllieMendes
Copy link

A little unclear about these props ( pill, size, state )

@AllieMendes can you help me with this?

image

Sorry for the delay @ManishBisht777, didn't see this.

The pill is a toggleable element, I recommend using the Dev Mode playground to test the components and what each property does:
image

Here is an example of where it's used:
image

The size is outdated, it seems, and the hover state is missing (but the property should exist).
I'll update the DS with the hover state.

If I take too long to answer, don't hesitate to ping me on Figma as it's easier for me to keep track of the conversation!

@ManishBisht777
Copy link
Contributor Author

A little unclear about these props ( pill, size, state )
@AllieMendes can you help me with this?
image

Sorry for the delay @ManishBisht777, didn't see this.

The pill is a toggleable element, I recommend using the Dev Mode playground to test the components and what each property does: image

Here is an example of where it's used: image

The size is outdated, it seems, and the hover state is missing (but the property should exist). I'll update the DS with the hover state.

If I take too long to answer, don't hesitate to ping me on Figma as it's easier for me to keep track of the conversation!

got it, thanks allie🚀

@AllieMendes
Copy link

No worries, let me know if you have any other questions :)

@AvineshTripathi
Copy link
Collaborator

Hey @ManishBisht777 how are we doing here, do you need any help or is this PR waiting for review ?

@ManishBisht777
Copy link
Contributor Author

hey @AvineshTripathi sorry completely forgot about this pr will will get back to in some time, sorry for the delay

@Azanul
Copy link
Collaborator

Azanul commented Mar 6, 2024

@ManishBisht777 status check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Card story with missing variants
4 participants