feat(taiko-client): soft block driver APIs #18273
Open
+3,630
−1,243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
reviewed
Oct 21, 2024
dantaik
reviewed
Oct 21, 2024
dantaik
reviewed
Oct 21, 2024
dantaik
approved these changes
Oct 21, 2024
|
added |
This reverts commit 22346fb.
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
dantaik
changed the title
davidtaikocha
requested review from
YoGhurt111,
cyberhorsey,
mask-pp and
dantaik
YoGhurt111
reviewed
Nov 6, 2024
mask-pp
reviewed
Nov 6, 2024
mask-pp
reviewed
Nov 7, 2024
mask-pp
reviewed
Nov 7, 2024
mask-pp
reviewed
Nov 7, 2024
mask-pp
reviewed
Nov 11, 2024
| return fmt.Errorf("failed to fetch last verified block hash: %w", err) | ||
| } | ||
|
|
||
| fc := &engine.ForkchoiceStateV1{ |
There was a problem hiding this comment.
We can only remove softblocks when calling this API, so the SafeBlockHash and FinalizedBlockHash aren't changed and there is no need to set them. Besides the SafeBlockHash is not right, it should be equal to canonicalHeadL1Origin.L2BlockHash.
mask-pp
reviewed
Nov 11, 2024
mask-pp
reviewed
Nov 12, 2024
mask-pp
reviewed
Nov 13, 2024
mask-pp
reviewed
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the latest design.
API preview: https://taikoxyz.github.io/taiko-mono/
taiko-geth changes: taikoxyz/taiko-geth#342