Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to test more fortran compilers #14

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Update CI to test more fortran compilers #14

merged 1 commit into from
Feb 22, 2024

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Feb 22, 2024

  • use fortran-lang/setup-fortran action to setup fortran compiler
  • add warning / fcheck gfortan compiler flags
  • use 4 cores when building
  • bump checkout action version
  • more output on failing tests
  • do both Debug and Release builds
  • for now comment out jobs with failing builds or tests

@lkeegan
Update CI to test more fortran compilers
38c5d6f 
- use fortran-lang/setup-fortran action to setup fortran compiler
- add warning / fcheck gfortan compiler flags
- use 4 cores when building
- bump checkout action version
- more output on failing tests
- do both Debug and Release builds
- for now comment out jobs with failing builds or tests
@lkeegan lkeegan mentioned this pull request Feb 22, 2024
Merged
@lkeegan lkeegan requested a review from rikardn February 22, 2024 10:10
rikardn
rikardn approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@rikardn rikardn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! This solves the MacOS issue, cleans up the fortran setup and makes it possible to test multiple versions of the compiler. Well done!

@rikardn rikardn merged commit 54ed7a9 into symengine:master Feb 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rikardn rikardn rikardn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lkeegan @rikardn