Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): added broken documentation link in login page #51

Conversation

acollazog11
Copy link
Contributor

No description provided.

Copy link
Contributor

@dev-bre dev-bre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a tabs (4spaces) indentation. Your PR is changing the indentation for the entire file

@acollazog11
Copy link
Contributor Author

Please use a tabs (4spaces) indentation. Your PR is changing the indentation for the entire file

Right!, I realized about that, but I was not sure what is the style guide in the project, others files like App.tsx, Flags.tsx, Segments.tsx, ... use a tab with 2 spaces indentation.
If the rule is 4 spaces, I can update it, but at some point it should be defined with eslint and/or prettier to avoid this for all contributors.

@dev-bre
Copy link
Contributor

dev-bre commented Jul 28, 2023

Good point. For this file, let's keep the same indentation that's already there. In a way that your PR would show only your actual changes.

As a separate issue, would you be interested in working on it and consolidate? The repo already uses Eslint. So it should be a matter of adding prettier and configure it properly.

Would you be interested in it?

@acollazog11
Copy link
Contributor Author

Sounds good!
I will update the PR. Then I can start working on configure Eslint and Prettier, I think that only with Eslint is enough to avoid adding other libs. So we can create a new issue for that and define which rules we want to add. I can write few rules in the issue as a start point.

@acollazog11
Copy link
Contributor Author

@dev-bre updated!! take a look now!

@dev-bre
Copy link
Contributor

dev-bre commented Jul 31, 2023

@acollazog11 looks good good idea on replacing the button with a link!

@dev-bre dev-bre merged commit 1feaa10 into switchfeat-com:main Jul 31, 2023
1 check passed
@acollazog11 acollazog11 deleted the bugfix/ui-broken-documentation-link-in-login-page branch July 31, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants