[CoroutineAccessors] Don't skip type-checking synthesized default implementations. #77661
+45
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always type-check the bodies of default implementations for `read2` and `modify2` requirements.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
@swift-ci please apple silicon benchmark |
slavapestov
reviewed
Nov 16, 2024
| @@ -938,24 +938,29 @@ buildIndexForwardingParamList(AbstractStorageDecl *storage, | |||
| return ParameterList::create(context, elements); | |||
| } | |||
|
|
|||
| bool AccessorDecl::isRequirementWithSynthesizedDefaultImplementation() const { | |||
There was a problem hiding this comment.
Methods declared in include/AST should be implemented in lib/AST
There was a problem hiding this comment.
(You can define a new request to break AST <-> Sema cycles)
|
Why do these need to be emitted even if we're skipping function bodies otherwise? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such bodies should be type-checked and emitted by SILGen accordingly.