Feature: Modular Assistive Driving System (MADS) #29
Conversation
# Conflicts: # opendbc/car/hyundai/carstate.py # opendbc/car/hyundai/interface.py
# Conflicts: # opendbc/car/hyundai/carstate.py # opendbc/car/hyundai/hyundaican.py # opendbc/car/hyundai/interface.py # opendbc/car/structs.py
# Conflicts: # opendbc/car/hyundai/carstate.py
opendbc/car/hyundai/carcontroller.py
Outdated
| @@ -6,7 +6,8 @@ | |||
| from opendbc.car.hyundai.carstate import CarState | |||
| from opendbc.car.hyundai.hyundaicanfd import CanBus | |||
| from opendbc.car.hyundai.values import HyundaiFlags, Buttons, CarControllerParams, CAR | |||
| from opendbc.car.interfaces import CarControllerBase | |||
|
|
|||
| from openpilot.sunnypilot.selfdrive.car.hyundai.carcontroller import CarControllerSP | |||
There was a problem hiding this comment.
Because this is defined on SP repo and not on opendbc, a reviewer would be unable to quickly see and understand what is this new controller bringing. We should keep make-specific changes together on the same repo.
see https://github.com/sunnypilot/sunnypilot/pull/446/files#r1843398527
opendbc/car/car.capnp
Outdated
| @@ -521,7 +521,7 @@ struct CarParams { | |||
| safetyModel @0 :SafetyModel; | |||
| safetyParam @3 :UInt16; | |||
| safetyParamDEPRECATED @1 :Int16; | |||
| safetyParam2DEPRECATED @2 :UInt32; | |||
| spFlags @2 :UInt32; | |||
There was a problem hiding this comment.
instead of introducing these flags here this way, we probably should do as the PR for ESCC introduces, where we are defining a structure for sunnyParams and there we can add both madsActive and flags (the later we already do)
opendbc/car/hyundai/values.py
Outdated
| @@ -99,6 +99,10 @@ class HyundaiFlags(IntFlag): | |||
| MIN_STEER_32_MPH = 2 ** 23 | |||
|
|
|||
|
|
|||
| class HyundaiFlagsSP(IntFlag): | |||
There was a problem hiding this comment.
We are achieving a greater separation from stock definitions by offloading this to it's own "module" within opendbc like this on ESCC https://github.com/sunnypilot/opendbc/pull/28/files#diff-ad070579ae1782339d2a8490c5e15b6d61894caa7cc374edd98a6bba1a2c6374
# Conflicts: # opendbc/car/car.capnp
No description provided yet. Please note: This is not ready for public use. Currently, it may contain bugs and mismatched states that could lead to bans for users who are not actively known SP developers. Please do not attempt to install at this time. However, feel free to review the code and leave comments if you have questions or concerns.
Relates to: