Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update of dual-time solver for species transport. #2260

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

bigfooted
Copy link
Contributor

Proposed Changes

This fixes the update of the dual time step for species transport, enabling transient simulations

Related Work

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

Copy link
Contributor

@Cristopher-Morales Cristopher-Morales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine for me, I am wondering why the Aachen turbo test case fails with this update.

@bigfooted
Copy link
Contributor Author

It looks fine for me, I am wondering why the Aachen turbo test case fails with this update.

I reran the regression and it passed, so it looks like some regression tests are not very deterministic.

@bigfooted bigfooted merged commit 4974020 into develop Apr 14, 2024
31 of 32 checks passed
@bigfooted bigfooted deleted the fix_unsteady_species branch April 14, 2024 19:25
@jblueh jblueh mentioned this pull request May 8, 2024
@jblueh jblueh mentioned this pull request May 29, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants