Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further Explicit Adjoints Locking and Lock-Free Adjoints Access #2161

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

jblueh
Copy link
Contributor

@jblueh jblueh commented Nov 7, 2023

Proposed Changes

  • Protect AD::GetDerivative() call trees by AD::BeginUseAdjoints(), AD::EndUseAdjoints().
  • GetAdjointSolution_time_n() and GetAdjointSolution_time_n1() use lock-free adjoints access now.

Related Work

continues #2146
related to #1984

PR Checklist

  • I am submitting my contribution to the develop branch.
  • My contribution generates no new compiler warnings (try with --warnlevel=3 when using meson).
  • My contribution is commented and consistent with SU2 style (https://su2code.github.io/docs_v7/Style-Guide/).
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have added a test case that demonstrates my contribution, if necessary.
  • I have updated appropriate documentation (Tutorials, Docs Page, config_template.cpp), if necessary.

@jblueh jblueh merged commit 5e82645 into develop Nov 8, 2023
31 checks passed
@jblueh jblueh deleted the more_explicit_locking branch November 8, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants