-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow selecting the zone used by the python wrapper (for multizone drivers) #2019
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the lead on this, you changed too many places, only the functions of the python wrapper (the ones in the pySU2 group) need to be changed.
The others are internal functions of the drivers that need to work on the zone the driver decides.
@afshawnlotfi is this working as expected? |
Sorry this last week has been busy, will verify by the end of this week. |
Proposed Changes
Added
SelectZone
function toCDriverBase
that dynamically sets the zone indexExample Usage
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.