Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict list of exported symbols via -export-symbols-regex #933

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

mbiebl
Copy link
Contributor

@mbiebl mbiebl commented Jul 5, 2023

While this approach doesn't cover every exported symbol (for that we should probably look into a version script), it at least catches the most common mistakes like in #918 (comment)

@StorageGhoul
Copy link

Can one of the admins verify this patch?

@mbiebl
Copy link
Contributor Author

mbiebl commented Jul 5, 2023

A more elaborate fix would probably involve symbol versioning and a version script. Not sure how well that would work with stub symbols and all. But if this is something you'd prefer, I could at least try to take a look.

The -export-symbols-regex is a rather cheap "hack" to avoid a bit of the whack-a-mole game we've been playing.

@vojtechtrefny
Copy link
Member

Jenkins, ok to test.

@vojtechtrefny
Copy link
Member

The -export-symbols-regex is a rather cheap "hack" to avoid a bit of the whack-a-mole game we've been playing.

I think this is a good temporary solution, we definitely need to do better in the future. I was thinking about adding the check you are running to our CI. It shouldn't be that hard to run it on the Ubuntu runners in GH actions.

@vojtechtrefny vojtechtrefny merged commit a211eea into storaged-project:master Jul 17, 2023
@tbzatek
Copy link
Member

tbzatek commented Jul 17, 2023

Oh nice, good idea with the regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants