Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the error status register and error interrupts #62

Merged
merged 5 commits into from
Nov 4, 2024

Conversation

guineawheek
Copy link
Contributor

This allows for handling error interrupts in SCE as well as reading the error status register's data as a nice struct.

@guineawheek
Copy link
Contributor Author

@adamgreig @dimpolo Would you mind taking a look at this? I'd love to hear your thoughts.

@dimpolo
Copy link

dimpolo commented Oct 24, 2024

Code looks good to me and matches the datasheet.

Would you say this line at the top of lib.rs can be removed now?

  • Support for querying error states and handling error interrupts is incomplete.

Have you had a chance to test if this works on hardware?

@guineawheek
Copy link
Contributor Author

Would you say this line at the top of lib.rs can be removed now?

I would say so, yes.

Have you had a chance to test if this works on hardware?

I've been running this code on production hardware. I'm pretty confident in its correctness there.

The previous maintainer did seem to have some sort of HIL test but testing on errors may be a bit hard to instrument.

@dimpolo
Copy link

dimpolo commented Oct 24, 2024

That all sounds good to me. If you could remove that comment we'll just need to wait for @adamgreig to sort out adding me as a maintainer :)

@guineawheek
Copy link
Contributor Author

The comment has been updated 👍

@adamgreig
Copy link
Member

@dimpolo, I've sent you an invitation to join the org and team that maintains this repo, feel free to go ahead and merge once you accept!

@dimpolo dimpolo merged commit 3ddfc77 into stm32-rs:master Nov 4, 2024
10 checks passed
@dimpolo
Copy link

dimpolo commented Nov 4, 2024

Thanks @guineawheek and @adamgreig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants