Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Math expansion #31

Merged
merged 31 commits into from
Aug 10, 2021
Merged

Math expansion #31

merged 31 commits into from
Aug 10, 2021

Conversation

phcreery
Copy link
Collaborator

@phcreery phcreery commented Aug 8, 2021

This PR is aimed at #30
It happens to have a list of other enhancements too.

  • : shortcuts to :=
  • Parentheses
  • pi!
  • Trigonometric Functions
  • Numbers do not default to float
    • Needs discussion
  • Evaluation Types
    • rewrite
      • image
    • expand
      • need to add \\expand to latex dictionary
    • simplify
    • factor
    • solve (for explicit variable)
      • Defaults to only variable if only 1 is used.
      • image

src/cas/pyodide-cas.ts Outdated Show resolved Hide resolved
Copy link
Owner

@stefnotch stefnotch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove the public/__pycache__/mathjson.cpython-38.pyc file? If you think that its easy to accidentally create a public/__pycache__ folder, feel free to add it to the .gitignore while you're at it.

public/mathjson.py Outdated Show resolved Hide resolved
@stefnotch
Copy link
Owner

This is looking pretty solid now! Its definitely a huge improvement over the status quo. While there are still parts that could be improved, I'd be happy to leave them for future pull requests.
What do you think?

Now the sympy code output is a bit more readable
@phcreery
Copy link
Collaborator Author

phcreery commented Aug 9, 2021

Thanks! Yea, most of these were the low hanging fruit. I'm cool with that. I will complete the review and pull this up from draft state.

@stefnotch stefnotch mentioned this pull request Aug 10, 2021
@phcreery phcreery marked this pull request as ready for review August 10, 2021 13:12
Copy link
Owner

@stefnotch stefnotch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@stefnotch stefnotch merged commit 52806ac into stefnotch:master Aug 10, 2021
@phcreery phcreery deleted the math-expansion branch August 19, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants