Track message sequences for Waku dogfooding #20
Conversation
adklempner
force-pushed
the
feat/waku-message-sequence
branch
2 times, most recently
from
99ce071
to
9bf0463
Compare
adklempner
force-pushed
the
feat/waku-message-sequence
branch
from
9bf0463
to
97dc3fc
Compare
adklempner
force-pushed
the
feat/waku-message-sequence
branch
3 times, most recently
from
d26f2a1
to
e66f3de
Compare
| id SERIAL PRIMARY KEY, | ||
| walletAddress VARCHAR(255), | ||
| peerIdSender VARCHAR(255) NOT NULL, | ||
| peerIdReporter VARCHAR(255) NOT NULL, |
There was a problem hiding this comment.
what is reporter in this context? is it the node that we sent message to?
There was a problem hiding this comment.
Reporter is the node being run by the same user who sends this data to telemetry. When sending a message via lightpush, reporter and sender will be the same.
|
|
||
| type TelemetryPushFilter struct { | ||
| ID int `json:"id"` | ||
| WalletAddress string `json:"walletAddress"` |
There was a problem hiding this comment.
seems we don't need it for dogfooding
There was a problem hiding this comment.
It's an optional field in the db table
| @@ -0,0 +1,14 @@ | |||
| CREATE TABLE IF NOT EXISTS errorSendingEnvelope ( | |||
There was a problem hiding this comment.
why do we need this table? it doesn't seem needed for dogfooding and maybe can be combined with other envelope tables?
There was a problem hiding this comment.
removed as it will be handled in separate PR after this one
| @@ -349,7 +358,65 @@ func (s *Server) rateLimit(next http.Handler) http.Handler { | |||
| }) | |||
| } | |||
|
|
|||
| func (s *Server) createWakuTelemetry(w http.ResponseWriter, r *http.Request) { | |||
adklempner
force-pushed
the
feat/waku-message-sequence
branch
3 times, most recently
from
2aba797
to
f9fef72
Compare
| if err != nil { | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
| defer stmt.Close() |
telemetry/server.go
Outdated
| return | ||
| } | ||
|
|
||
| var errorDetails []map[string]interface{} |
There was a problem hiding this comment.
Wouldn't it be better to create a type instead?
type ErrorDetail struct {
Id string `json:"Id"`
Error string `json:"Error"`
}
And then use that type in
var errorDetails []map[string]ErrorDetail
There was a problem hiding this comment.
added and included in http response when errors are encountered
adklempner
force-pushed
the
feat/waku-message-sequence
branch
from
f9fef72
to
0edd777
Compare
Adds a table and endpoint for tracking Waku data for the dogfooding app
This shouldn't effect any status-related telemetry