Merge pull request #68 from status-im/fix/optional-log

fix: add option to log when appending error
status-im · Oct 21, 2024 · ab3fd88 · ab3fd88
2 parents 9c25d22 + 467f3c5
commit ab3fd88
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/common/errors.go b/lib/common/errors.go
@@ -23,8 +23,8 @@ func NewMetricErrors(logger *zap.Logger) *MetricErrors {
 	}
 }
 
-func (me *MetricErrors) Append(id int, err string) {
-	if me.logger != nil {
+func (me *MetricErrors) Append(id int, err string, skipLogging ...bool) {
+	if me.logger != nil && (len(skipLogging) == 0 || !skipLogging[0]) {
 		me.logger.Error(err)
 	}
 	me.mutex.Lock()

diff --git a/telemetry/server.go b/telemetry/server.go
@@ -243,7 +243,7 @@ func (s *Server) createWakuTelemetry(w http.ResponseWriter, r *http.Request) {
 			}
 			if err := pushFilter.Put(s.DB); err != nil {
 				if strings.Contains(err.Error(), "duplicate key value violates unique constraint") {
-					errorDetails.Append(data.Id, "Error saving lightpush/filter metric: Duplicate key value violates unique constraint")
+					errorDetails.Append(data.Id, "Error saving lightpush/filter metric: Duplicate key value violates unique constraint", true)
 					continue
 				}
 				errorDetails.Append(data.Id, fmt.Sprintf("Error saving lightpush/filter metric: %v", err))