Add tabs variants and remove blur #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0cf747f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@prichodko is attempting to deploy a commit to the Status Team on Vercel. A member of the Team first needs to authorize it. |
prichodko
commented
Oct 27, 2023
| backgroundColor: '$neutral-20', | ||
| }, | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore |
There was a problem hiding this comment.
I couldn't figure out how to fix this error in Tamagui, even though it's a valid syntax.
There was a problem hiding this comment.
Giving the function a type explicitly breaks type inference.
marcelines
approved these changes
Oct 27, 2023
| default: '$neutral-100', | ||
| hover: '$neutral-100', | ||
| press: '$neutral-100', | ||
| default: variant === 'blur_darkGrey' ? '$white-100' : '$neutral-100', |
There was a problem hiding this comment.
Can't we use a const for now to avoid repetition?
felicio
reviewed
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted-in into explicitly declaring a variant because there is no obvious "default". WDYT?
Removing
backdrop-blurbecause of unexpected issues it is causing (example in the video):Screen.Recording.2023-10-27.at.12.24.09.mov