Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ContextTag style #478

Merged
merged 3 commits into from
Sep 25, 2023
Merged

fix ContextTag style #478

merged 3 commits into from
Sep 25, 2023

Conversation

felicio
Copy link
Collaborator

@felicio felicio commented Sep 14, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2023

🦋 Changeset detected

Latest commit: 65e2a3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@status-im/components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 14, 2023

@felicio is attempting to deploy a commit to the Status Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
status-components ⬜️ Ignored (Inspect) Visit Preview Sep 15, 2023 9:23am
status-web ⬜️ Ignored (Inspect) Visit Preview Sep 15, 2023 9:23am

Copy link
Collaborator Author

@felicio felicio Sep 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: ContextTag keeps on giving and has more to give. I keep bumping into slight differences, not always related to what I need to change.

More things to address being, for example,

  • diff monospace font/look
  • 1px diff in padding due to outline vs. border
  • border radius
  • gap of icon type
  • diff in horizontal padding of icon type

However, I don't know how to address the above (more conditional rendering) in the ideal and maintainable way right now. If you do, please let me know, otherwise I'd create a follow-up issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felicio felicio merged commit b560d62 into status-im:main Sep 25, 2023
3 checks passed
@felicio felicio self-assigned this May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants