Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/request payment modal 16736 #16744

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Cuteivist
Copy link
Contributor

Closes #16736

What does the PR do

  • Added feature flag for Request Payment. Disabled until whole feature is finished
  • Added Request payment modal
  • Added menu for message commands (now featuring add image and add request payment). Request payment is disabled for testnet to prevent corner cases or issues.
  • Added RequestPaymentStore to easily pass required models and stores to modal
  • Updated storybook

Affected areas

Architecture compliance

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

image

image

Impact on end user

What is the impact of these changes on the end user (before/after behaviour)

How to test

  • How should one proceed with testing this PR.
    Enable request payment feature flag, go to any chat on mainnet.
  • What kind of user flows should be checked?

Risk

Described potential risks and worst case scenarios.

Tick one:

  • Low risk: 2 devs MUST perform testing as specified above and attach their results as comments to this PR before merging.
  • High risk: QA team MUST perform additional testing in the specified affected areas before merging.

@status-im-auto
Copy link
Member

status-im-auto commented Nov 11, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
cfc1b4c #1 2024-11-11 14:26:13 ~7 min macos/aarch64 📄log
✖️ cfc1b4c #1 2024-11-11 14:26:28 ~7 min tests/nim 📄log
cfc1b4c #1 2024-11-11 14:29:04 ~9 min tests/ui 📄log
cfc1b4c #1 2024-11-11 14:29:38 ~10 min linux-nix/x86_64 📄log
cfc1b4c #1 2024-11-11 14:30:47 ~11 min macos/x86_64 📄log
cfc1b4c #1 2024-11-11 14:30:48 ~11 min linux/x86_64 📄log
cfc1b4c #1 2024-11-11 14:33:09 ~13 min windows/x86_64 📄log

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, apart from the vertical (mis)alignment between the amount and the token selector when looking at the screenshot :)

if (!valid)
return 0

return parseFloat(text.replace(LocaleUtils.userInputLocale.decimalPoint, "."))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we fine with loss of precision here? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request payment - modal
3 participants