feat(@desktop/wallet): Adapt Token Selector #16733
Open
+203
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins Builds
|
Khushboo-dev-cpp
requested review from
micieslak,
a team,
caybro and
alexjba
as code owners
Khushboo-dev-cpp
requested review from
Cuteivist
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #16702
What does the PR do
Adapts the TokenSelectors and its components to adapt to new design from Ben here -
https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25229-108897&t=Ech2sOd4zCGhGFzC-4
https://www.figma.com/design/FkFClTCYKf83RJWoifWgoX/Wallet-v2?node-id=25232-114042&t=x7Ukt7ixxp7Ji84n-4
Affected areas
TokenSelector
SendModal
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality (including design for comparison)
Token Selector Button size is not 24 not 21.
https://github.com/user-attachments/assets/6947b3d8-4256-4f4e-83ac-454781c6db41
Searchable Assets and Collectibles now have padding of 4px and spacing of 4x.
On Hover Collectible shows contract network
Only 5.5 items are shown
On search the top item is highlighted and user can press enter to quickly select it.
https://github.com/user-attachments/assets/d06cc015-3c1b-448c-8377-042616db8a62
Empty Collectibles list state
